Tuesday, August 6, 2013

Updates on the PSurface project


Last week I modified the vtu and hdf5 io code according to Markus'  guide to make it  looks better:
1. Changed the method and class names according to Camel-case  to adhere to dune guidelines.
2. Remove all the indent and trailing white space in the code.
3. Put all the functions that deals with io into one class(vtkPWriter). 
4.Extend the template parameters of vtkPWriter. It could only deal with 2 dimensional psurface and float. Not it support 1 dimensional psurface, and the float.
5. Use command line parameters to get the input filename. 
The modified code have been pushed to git://gitorious.org/gcos/psurface-convert.git
6.document the code using doxygen syntax.
Issues that I have not solved includes:
+ Moving headers
"Some your headers seem to be usable by other programs. E.g. one might want to read xmf files in one's own applications. This headers should be under dune and be installed, the cpp file should become part of a library. You can see how this is done in dune-common/dune/common. "
+The include path issue
  What is up with the weired AC_ARG_WITH clauses in configure.ac? I do not
   think that they are needed and doubt that they serve their intended
   purpose.

I will address these issues in the next week  and then move to task #3.1: construct a PSurface object from HDF5 file.

No comments:

Post a Comment